Stop Doing Pull Requests

by champagnepapion 11/17/2023, 2:21 AMwith 4 comments

by dexwizon 11/17/2023, 2:30 AM

Sounds like you have a culture problem. You can always open a PR and then discuss it in person or over chat. If your teammates take weeks to review your work, then your manager needs to step in. If nothing changes, then the culture is broken or you need to take a hint. Maybe your 50 file PR is too big and too complex to approach.

I think PRs work best when it’s mostly a sanity check and rubber stamp for those you trust on small changes. But big changes or unfamiliar colleagues get a bit more scrutiny. Checking in code works best at regular intervals. Combined with good tests, checking in code does r have to be a hassle.